:reload
#374
Merged
:reload
#374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudormrfbin
reviewed
Jun 25, 2021
archseer
reviewed
Jun 26, 2021
|
I've also added an |
|
I'll move the simd into a separate PR. |
kirawi
commented
Jul 2, 2021
cessen
reviewed
Jul 2, 2021
cessen
reviewed
Jul 2, 2021
|
Over-all, this looks really great. The only comment I made that I really care about getting addressed is the one about the timeout length. But other than that, as far as I'm concerned it looks good to merge. Really clear, clean code. Awesome job! |
|
Addressed the stuff in the review :) |
cessen
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was only updated enough to pass compilation. I'll need to do some more work to get it working properly.
I wonder if there's a way to be performant without usingRemovedunsafe.unsafefor now.